Repository navigation
Conversation
weiminyu
requested changes
Nov 12, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
There was a problem hiding this comment.
@weiminyu made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on jicelhay).
core/src/main/java/google/registry/tools/ListDomainsCommand.java line 46 at r1 (raw file):
+ MAX_DOMAINS + " domains per request and returns an error if more match.") private int maxDomains = Integer.MAX_VALUE;
Should we change the initial value and verify user provided one if present?
Code quote:
maxDomains = Integer.MAX_VALUEThis branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListDomainsAction loads every matching domain into memory before responding, which can exhaust the server's memory when listing many or large TLDs.
This caps a single request at 10,000 domains. If more than that match and no --limit of 10,000 or less is given, the action returns an error rather than a silently truncated list. Listings of up to 10,000 domains, and any request with --limit of 10,000 or less, behave as before.
The --limit help text now mentions the cap.
b/585183729
This change is